🩹 [Patch]: Update condition checks for version strings in Publish-PSModule script

MariusStorhaug · MariusStorhaug · commit 74c26dc20df2 · 2025-06-02T00:11:25.000+02:00
diff --git a/action.yml b/action.yml
@@ -80,7 +80,7 @@ runs:
   using: composite
   steps:
     - name: Install-PSModuleHelpers
-      uses: PSModule/Install-PSModuleHelpers@v1
+      uses: PSModule/Install-PSModuleHelpers@removeInit
 
     - name: Run Publish-PSModule
       uses: PSModule/GitHub-Script@v1
diff --git a/scripts/helpers/Publish-PSModule.ps1 b/scripts/helpers/Publish-PSModule.ps1
@@ -145,7 +145,7 @@
         $latestRelease = $releases | Where-Object { $_.isLatest -eq $true }
         $latestRelease | Format-List | Out-String
         $ghReleaseVersionString = $latestRelease.tagName
-        if ($ghReleaseVersionString | IsNotNullOrEmpty) {
+        if (-not [string]::IsNullOrEmpty($ghReleaseVersionString)) {
             $ghReleaseVersion = New-PSSemVer -Version $ghReleaseVersionString
         } else {
             Write-Warning 'Could not find the latest release version. Using ''0.0.0'' as the version.'
@@ -197,7 +197,7 @@
         try {
             $manifestVersion = New-PSSemVer -Version (Test-ModuleManifest $manifestFilePath -Verbose:$false).Version
         } catch {
-            if ($manifestVersion | IsNullOrEmpty) {
+            if ([string]::IsNullOrEmpty($manifestVersion)) {
                 Write-Warning 'Could not find the module version in the manifest. Using ''0.0.0'' as the version.'
                 $manifestVersion = New-PSSemVer -Version '0.0.0'
             }
@@ -248,7 +248,7 @@
             $newVersion.Prerelease = $prereleaseName
             Write-Output "Partial new version: [$newVersion]"
 
-            if ($datePrereleaseFormat | IsNotNullOrEmpty) {
+            if (-not [string]::IsNullOrEmpty($datePrereleaseFormat)) {
                 Write-Output "Using date-based prerelease: [$datePrereleaseFormat]."
                 $newVersion.Prerelease += "$(Get-Date -Format $datePrereleaseFormat)"
                 Write-Output "Partial new version: [$newVersion]"
