🪲 [Fix]: Fix script path and improve test result handling (#91)

MariusStorhaug · web-flow · commit e96fb1569b3d · 2025-01-30T22:36:26.000+01:00
## Description This pull request includes changes to the GitHub Actions workflow and the PowerShell script used for testing. The most important changes include updating the script path in the action configuration and modifying the handling of test results in the PowerShell script. ### Workflow Updates: * [`action.yml`](diffhunk://#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6L72-R72): Updated the script path in the `runs:` section to use a more straightforward syntax. ### Script Enhancements: * [`scripts/main.ps1`](diffhunk://#diff-dc2e5a659836b1b73abb03421c567f5018c2755677c4a0aa764cb26117b68011R53-R63): Improved the handling of test results by setting GitHub output values for passed tests and using a return variable to determine the exit code. ## Type of change  - [ ] 📖 [Docs] - [x] 🪲 [Fix] - [ ] 🩹 [Patch] - [ ] ⚠️ [Security fix] - [ ] 🚀 [Feature] - [ ] 🌟 [Breaking change] ## Checklist  - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas
diff --git a/action.yml b/action.yml
@@ -69,7 +69,7 @@ runs:
         ShowOutput: true
         Script: |
           # Test-PSModule
-          . (Join-Path -Path '${{ github.action_path }}' -ChildPath 'scripts\main.ps1')
+          ${{ github.action_path }}/scripts/main.ps1
 
     - name: Upload test results
       uses: actions/upload-artifact@v4
diff --git a/scripts/main.ps1 b/scripts/main.ps1
@@ -50,11 +50,14 @@ $failedTests = [int]$testResults.FailedCount
 
 if (($failedTests -gt 0) -or ($testResults.Result -ne 'Passed')) {
     Write-GitHubError "❌ Some [$failedTests] tests failed."
+    Set-GitHubOutput -Name 'passed' -Value $false
+    $return = 1
 }
 if ($failedTests -eq 0) {
     Write-GitHubNotice '✅ All tests passed.'
+    Set-GitHubOutput -Name 'passed' -Value $true
+    $return = 0
 }
 
-Set-GitHubOutput -Name 'passed' -Value ($failedTests -eq 0)
 Write-Host '━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━'
-exit $failedTests
+exit $return
