feat: update wording for errors to be more clear

william2958 · william2958 · commit a48f99db9f8c · 2022-07-01T13:57:39.000-04:00
diff --git a/libraries/rush-lib/src/api/RushConfiguration.ts b/libraries/rush-lib/src/api/RushConfiguration.ts
@@ -808,7 +808,7 @@ export class RushConfiguration {
         if (!this.getProjectByName(decoupledLocalDependency)) {
           throw new Error(
             `In rush.json, the "${decoupledLocalDependency}" project does not exist,` +
-              ` but was referenced by the decoupledLocalDependencies for ${project.packageName}`
+              ` but was referenced by the decoupledLocalDependencies (previously cyclicDependencyProjects) for ${project.packageName}`
           );
         }
       });
diff --git a/libraries/rush-lib/src/api/RushConfigurationProject.ts b/libraries/rush-lib/src/api/RushConfigurationProject.ts
@@ -162,7 +162,7 @@ export class RushConfigurationProject {
     if (projectJson.cyclicDependencyProjects || projectJson.decoupledLocalDependencies) {
       if (projectJson.cyclicDependencyProjects && projectJson.decoupledLocalDependencies) {
         throw new Error(
-          'A project cannot have both decoupledLocalDependencies as well as cyclicDependencyProjects. Please only use the decoupledLocalDependencies instead.'
+          'A project configuration cannot have both decoupledLocalDependencies as well as cyclicDependencyProjects fields. Please only use the decoupledLocalDependencies configuration instead.'
         );
       }
       for (const cyclicDependencyProject of projectJson.cyclicDependencyProjects ||

Original file line number	Diff line number	Diff line change
`@@ -808,7 +808,7 @@ export class RushConfiguration {`
`808`	`808`	`if (!this.getProjectByName(decoupledLocalDependency)) {`
`809`	`809`	`throw new Error(`
`810`	`810`	`In rush.json, the "${decoupledLocalDependency}" project does not exist,` +
`811`		- ` but was referenced by the decoupledLocalDependencies for ${project.packageName}`
	`811`	+ ` but was referenced by the decoupledLocalDependencies (previously cyclicDependencyProjects) for ${project.packageName}`
`812`	`812`	`);`
`813`	`813`	`}`
`814`	`814`	`});`
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ export class RushConfigurationProject {`
`162`	`162`	`if (projectJson.cyclicDependencyProjects \|\| projectJson.decoupledLocalDependencies) {`
`163`	`163`	`if (projectJson.cyclicDependencyProjects && projectJson.decoupledLocalDependencies) {`
`164`	`164`	`throw new Error(`
`165`		`- 'A project cannot have both decoupledLocalDependencies as well as cyclicDependencyProjects. Please only use the decoupledLocalDependencies instead.'`
	`165`	`+ 'A project configuration cannot have both decoupledLocalDependencies as well as cyclicDependencyProjects fields. Please only use the decoupledLocalDependencies configuration instead.'`
`166`	`166`	`);`
`167`	`167`	`}`
`168`	`168`	`for (const cyclicDependencyProject of projectJson.cyclicDependencyProjects \|\|`