Enable the chmod normalization by default. Use the flag to disable.

sachinjoseph · sachinjoseph · commit e24d8437454a · 2020-04-07T21:30:10.000-07:00
diff --git a/apps/rush-lib/src/api/ExperimentsConfiguration.ts b/apps/rush-lib/src/api/ExperimentsConfiguration.ts
@@ -21,10 +21,10 @@ export interface IExperimentsJson {
   legacyIncrementalBuildDependencyDetection?: boolean;
 
   /**
-   * If true, the chmod field in temporary project tar headers will be set to 755.
-   * This can help ensure consistent tarball integrity across platforms.
+   * If true, the chmod field in temporary project tar headers will not be normalized.
+   * This normalization can help ensure consistent tarball integrity across platforms.
    */
-  normalizeChmodFieldInTarHeader?: boolean;
+  noChmodFieldInTarHeaderNormalization?: boolean;
 }
 
 /**
diff --git a/apps/rush-lib/src/logic/InstallManager.ts b/apps/rush-lib/src/logic/InstallManager.ts
@@ -746,8 +746,8 @@ export class InstallManager {
             sync: true,
             prefix: npmPackageFolder,
             filter: (path: string, stat: tar.FileStat): boolean => {
-              if (this._rushConfiguration.experimentsConfiguration.configuration
-                .normalizeChmodFieldInTarHeader) {
+              if (!this._rushConfiguration.experimentsConfiguration.configuration
+                .noChmodFieldInTarHeaderNormalization) {
 
                 stat.mode = (stat.mode & ~0x1FF) | PosixModeBits.AllRead | PosixModeBits.UserWrite
                   | PosixModeBits.AllExecute;
diff --git a/apps/rush-lib/src/schemas/experiments.schema.json b/apps/rush-lib/src/schemas/experiments.schema.json
@@ -15,8 +15,8 @@
       "type": "boolean"
     },
 
-    "normalizeChmodFieldInTarHeader": {
-      "description": "If true, the chmod field in temporary project tar headers will be set to 755. This can help ensure consistent tarball integrity across platforms.",
+    "noChmodFieldInTarHeaderNormalization": {
+      "description": "If true, the chmod field in temporary project tar headers will not be normalized. This normalization can help ensure consistent tarball integrity across platforms.",
       "type": "boolean"
     }
   },
diff --git a/common/reviews/api/rush-lib.api.md b/common/reviews/api/rush-lib.api.md
@@ -134,7 +134,7 @@ export interface IConfigurationEnvironmentVariable {
 // @beta
 export interface IExperimentsJson {
     legacyIncrementalBuildDependencyDetection?: boolean;
-    normalizeChmodFieldInTarHeader?: boolean;
+    noChmodFieldInTarHeaderNormalization?: boolean;
 }
 
 // @public

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ export interface IConfigurationEnvironmentVariable {`
`134`	`134`	`// @beta`
`135`	`135`	`export interface IExperimentsJson {`
`136`	`136`	`legacyIncrementalBuildDependencyDetection?: boolean;`
`137`		`- normalizeChmodFieldInTarHeader?: boolean;`
	`137`	`+ noChmodFieldInTarHeaderNormalization?: boolean;`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`// @public`