-
Notifications
You must be signed in to change notification settings - Fork 373
Manually set the scroll parent element #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @joelcuevas @cristianda , thanks for your suggestion, let's discuss here. Through your description, I also think support customize scroll container is very useful and important, but the key point is, which is the elegant way? In order to make it easier to use, I recommend add a customize attribute to identify the real scroll parent rather than passing scroll parent as a property, because we should to avoid handling DOM directly, template maybe like this: <div class="customize-scroll-container" some-special-attribute>
...
<infinite-loading></infinite-loading>
</div> And this plugin will find the element which has How do you think about it? |
I have the same problem, please let me know if you found a workaround. |
@cristiandan maybe you missed my previous comment? We commented this issue almost at the same time. 🤦♂️ |
Sorry, I think we wrote at the same time. Thanks! |
The special attribute sounds nicer to me too! Do you need some help with this? |
Of course! We need to name the special attribute, such as |
I think infinite-wrapper sounds good! |
No problem, it's called |
Are you planning to release 2.1.0 soon? I'm anxious to start using this new feature on a project 😄 |
@kronicker of course! But as you can see, I have not finished testing yet, I will as soon as possible... |
Hi @joelcuevas, @cristiandan and @kronicker , I have already released a new version But it cannot work directly with |
@PeachScript Already tested it with perfect-scrollbar, works like a charm. Thanks for your work!! |
You're welcome! 😄 |
That's awesome, thanks a lot @PeachScript ! |
Uh oh!
There was an error while loading. Please reload this page.
For vue-infinite-loading v1.3.0.
Currently I'm using perfect-scrollbar. It sets the overflow-y property to "hidden" on the scrollable container, causing that vue-infinite-loading doesn't find the correct parent (which is expected to have overflow-y "scroll" or "auto"). If I set the scroll parent to the correct one (hardcoding for debugging purposes), both libraries get along pretty fine.
@PeachScript do you think that passing the scroll parent on a property could be a good idea? Another libraries are doing this, but I like yours the most, so I gladfully could do a PR.
Do you have a different suggestion?
Thanks!
The text was updated successfully, but these errors were encountered: