(perl #132245) don't leak on \N{}

tonycoz · tonycoz · commit ebcc725e3f7e · 2017-10-30T10:37:32.000+11:00
get_and_check_backslash_N_name() failed to free its working SV if
the name was empty.
diff --git a/t/op/svleak.t b/t/op/svleak.t
@@ -15,7 +15,7 @@ BEGIN {
 
 use Config;
 
-plan tests => 141;
+plan tests => 142;
 
 # run some code N times. If the number of SVs at the end of loop N is
 # greater than (N-1)*delta at the end of loop 1, we've got a leak
@@ -593,3 +593,8 @@ EOF
     }
     ::leak(2, 0, \&named, "Perl_reg_named_buff_fetch() on no-name RE");
 }
+
+{
+    sub N_leak { eval 'tr//\N{}-0/' }
+    ::leak(2, 0, \&N_leak, "a bad \\N{} in a range leaks");
+}
diff --git a/toke.c b/toke.c
@@ -2595,6 +2595,7 @@ S_get_and_check_backslash_N_name(pTHX_ const char* s, const char* const e)
     PERL_ARGS_ASSERT_GET_AND_CHECK_BACKSLASH_N_NAME;
 
     if (!SvCUR(res)) {
+        SvREFCNT_dec_NN(res);
         /* diag_listed_as: Unknown charname '%s' */
         yyerror("Unknown charname ''");
         return NULL;

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ BEGIN {`
`15`	`15`
`16`	`16`	`use Config;`
`17`	`17`
`18`		`-plan tests => 141;`
	`18`	`+plan tests => 142;`
`19`	`19`
`20`	`20`	`# run some code N times. If the number of SVs at the end of loop N is`
`21`	`21`	`# greater than (N-1)*delta at the end of loop 1, we've got a leak`
`@@ -593,3 +593,8 @@ EOF`
`593`	`593`	`}`
`594`	`594`	`::leak(2, 0, \&named, "Perl_reg_named_buff_fetch() on no-name RE");`
`595`	`595`	`}`
	`596`	`+`
	`597`	`+{`
	`598`	`+ sub N_leak { eval 'tr//\N{}-0/' }`
	`599`	`+ ::leak(2, 0, \&N_leak, "a bad \\N{} in a range leaks");`
	`600`	`+}`