Update 04_recursive_max.js with fix for alternative solution (egonSchiele#262)

TrayHard · Ilia Poliakov · web-flow · commit 00b28478ce17 · 2024-12-07T07:44:23.000-06:00
* Update 04_recursive_max.js with fix for alternative solution

Current alternative solution works only for arrays of natural numbers and for empty arrays it returns 0 instead of null or Error. This commit fixes these problems.

* Considering comments from the author

---------

Co-authored-by: Ilia Poliakov &lt;ilia.poliakov@macys.com&gt;
diff --git a/04_quicksort/javascript/04_recursive_max.js b/04_quicksort/javascript/04_recursive_max.js
@@ -14,16 +14,19 @@ function max(array) {
 
 /**
  * Calculate the largest number
- * This solution works for arrays of any length
+ * This solution works for arrays of any length and returns the smallest possible number for empty arrays
  * @param {Array} array Array of numbers
  * @param {number} max Maximum value
- * @returns {number} The argest number
+ * @returns {number} The largest number
  */
-function alternativeSolutionMax(array, max = 0) {
+function alternativeSolutionMax(array, max = Number.MIN_VALUE) {
   return array.length === 0
     ? max
     : alternativeSolutionMax(array.slice(1), array[0] > max ? array[0] : max);
 }
 
 console.log(max([1, 5, 10, 25, 16, 1])); // 25
 console.log(alternativeSolutionMax([1, 5, 10, 25, 16, 1])); // 25
+
+console.log(max([])); // RangeError: Maximum call stack size exceeded
+console.log(alternativeSolutionMax([])); // Number.MIN_VALUE
