Drop optional parameters in ReferenceCollectionExtensions.cs

shiftkey · nulltoken · commit bce3f4c1320e · 2015-05-15T19:31:41.000+02:00
diff --git a/LibGit2Sharp/ReferenceCollectionExtensions.cs b/LibGit2Sharp/ReferenceCollectionExtensions.cs
@@ -32,6 +32,20 @@ private static RefState TryResolveReference(out Reference reference, ReferenceCo
             return reference != null ? RefState.Exists : RefState.DoesNotExistButLooksValid;
         }
 
+        /// <summary>
+        /// Creates a direct or symbolic reference with the specified name and target
+        /// </summary>
+        /// <param name="refsColl">The <see cref="ReferenceCollection"/> being worked with.</param>
+        /// <param name="name">The name of the reference to create.</param>
+        /// <param name="canonicalRefNameOrObjectish">The target which can be either the canonical name of a reference or a revparse spec.</param>
+        /// <param name="logMessage">The optional message to log in the <see cref="ReflogCollection"/> when adding the <see cref="Reference"/></param>
+        /// <returns>A new <see cref="Reference"/>.</returns>
+        public static Reference Add(this ReferenceCollection refsColl, string name, string canonicalRefNameOrObjectish,
+            string logMessage)
+        {
+            return refsColl.Add(name, canonicalRefNameOrObjectish, logMessage, false);
+        }
+
         /// <summary>
         /// Creates a direct or symbolic reference with the specified name and target
         /// </summary>
@@ -41,7 +55,7 @@ private static RefState TryResolveReference(out Reference reference, ReferenceCo
         /// <param name="logMessage">The optional message to log in the <see cref="ReflogCollection"/> when adding the <see cref="Reference"/></param>
         /// <param name="allowOverwrite">True to allow silent overwriting a potentially existing reference, false otherwise.</param>
         /// <returns>A new <see cref="Reference"/>.</returns>
-        public static Reference Add(this ReferenceCollection refsColl, string name, string canonicalRefNameOrObjectish, string logMessage, bool allowOverwrite = false)
+        public static Reference Add(this ReferenceCollection refsColl, string name, string canonicalRefNameOrObjectish, string logMessage, bool allowOverwrite)
         {
             Ensure.ArgumentNotNullOrEmptyString(name, "name");
             Ensure.ArgumentNotNullOrEmptyString(canonicalRefNameOrObjectish, "canonicalRefNameOrObjectish");
@@ -77,6 +91,19 @@ public static Reference Add(this ReferenceCollection refsColl, string name, stri
             return refsColl.Add(name, gitObject.Id, logMessage, allowOverwrite);
         }
 
+
+        /// <summary>
+        /// Creates a direct or symbolic reference with the specified name and target
+        /// </summary>
+        /// <param name="refsColl">The <see cref="ReferenceCollection"/> being worked with.</param>
+        /// <param name="name">The name of the reference to create.</param>
+        /// <param name="canonicalRefNameOrObjectish">The target which can be either the canonical name of a reference or a revparse spec.</param>
+        /// <returns>A new <see cref="Reference"/>.</returns>
+        public static Reference Add(this ReferenceCollection refsColl, string name, string canonicalRefNameOrObjectish)
+        {
+            return Add(refsColl, name, canonicalRefNameOrObjectish, null, false);
+        }
+
         /// <summary>
         /// Creates a direct or symbolic reference with the specified name and target
         /// </summary>
@@ -85,7 +112,7 @@ public static Reference Add(this ReferenceCollection refsColl, string name, stri
         /// <param name="canonicalRefNameOrObjectish">The target which can be either the canonical name of a reference or a revparse spec.</param>
         /// <param name="allowOverwrite">True to allow silent overwriting a potentially existing reference, false otherwise.</param>
         /// <returns>A new <see cref="Reference"/>.</returns>
-        public static Reference Add(this ReferenceCollection refsColl, string name, string canonicalRefNameOrObjectish, bool allowOverwrite = false)
+        public static Reference Add(this ReferenceCollection refsColl, string name, string canonicalRefNameOrObjectish, bool allowOverwrite)
         {
             return Add(refsColl, name, canonicalRefNameOrObjectish, null, allowOverwrite);
         }
@@ -122,6 +149,46 @@ public static Reference UpdateTarget(this ReferenceCollection refsColl, Referenc
             return UpdateTarget(refsColl, directRef, objectish, null);
         }
 
+        /// <summary>
+        /// Rename an existing reference with a new name
+        /// </summary>
+        /// <param name="currentName">The canonical name of the reference to rename.</param>
+        /// <param name="newName">The new canonical name.</param>
+        /// <param name="refsColl">The <see cref="ReferenceCollection"/> being worked with.</param>
+        /// <returns>A new <see cref="Reference"/>.</returns>
+        public static Reference Rename(this ReferenceCollection refsColl, string currentName, string newName)
+        {
+            return refsColl.Rename(currentName, newName, null, false);
+        }
+
+        /// <summary>
+        /// Rename an existing reference with a new name
+        /// </summary>
+        /// <param name="currentName">The canonical name of the reference to rename.</param>
+        /// <param name="newName">The new canonical name.</param>
+        /// <param name="allowOverwrite">True to allow silent overwriting a potentially existing reference, false otherwise.</param>
+        /// <param name="refsColl">The <see cref="ReferenceCollection"/> being worked with.</param>
+        /// <returns>A new <see cref="Reference"/>.</returns>
+        public static Reference Rename(this ReferenceCollection refsColl, string currentName, string newName,
+            bool allowOverwrite)
+        {
+            return refsColl.Rename(currentName, newName, null, allowOverwrite);
+        }
+
+        /// <summary>
+        /// Rename an existing reference with a new name
+        /// </summary>
+        /// <param name="currentName">The canonical name of the reference to rename.</param>
+        /// <param name="newName">The new canonical name.</param>
+        /// <param name="logMessage">The optional message to log in the <see cref="ReflogCollection"/></param>
+        /// <param name="refsColl">The <see cref="ReferenceCollection"/> being worked with.</param>
+        /// <returns>A new <see cref="Reference"/>.</returns>
+        public static Reference Rename(this ReferenceCollection refsColl, string currentName, string newName,
+            string logMessage)
+        {
+            return refsColl.Rename(currentName, newName, logMessage, false);
+        }
+
         /// <summary>
         /// Rename an existing reference with a new name
         /// </summary>
@@ -132,7 +199,7 @@ public static Reference UpdateTarget(this ReferenceCollection refsColl, Referenc
         /// <param name="refsColl">The <see cref="ReferenceCollection"/> being worked with.</param>
         /// <returns>A new <see cref="Reference"/>.</returns>
         public static Reference Rename(this ReferenceCollection refsColl, string currentName, string newName,
-            string logMessage = null, bool allowOverwrite = false)
+            string logMessage, bool allowOverwrite)
         {
             Ensure.ArgumentNotNullOrEmptyString(currentName, "currentName");
 
