Drop optional parameters in CommitRewriteInfo.cs

shiftkey · nulltoken · commit d7e8a2e915f4 · 2015-05-15T19:31:45.000+02:00
diff --git a/LibGit2Sharp/CommitRewriteInfo.cs b/LibGit2Sharp/CommitRewriteInfo.cs
@@ -35,6 +35,46 @@ public static CommitRewriteInfo From(Commit commit)
                 };
         }
 
+         /// <summary>
+         /// Build a <see cref="CommitRewriteInfo"/> from the <see cref="Commit"/> passed in,
+         /// optionally overriding some of its properties
+         /// </summary>
+         /// <param name="commit">The <see cref="Commit"/> whose information is to be copied</param>
+        /// <param name="author">Optional override for the author</param>
+        /// <returns>A new <see cref="CommitRewriteInfo"/> object that matches the info for the
+        /// <paramref name="commit"/> with the optional parameters replaced..</returns>
+        public static CommitRewriteInfo From(Commit commit, Signature author)
+        {
+            return From(commit, author, null, null);
+        }
+
+        /// <summary>
+        /// Build a <see cref="CommitRewriteInfo"/> from the <see cref="Commit"/> passed in,
+        /// optionally overriding some of its properties
+        /// </summary>
+        /// <param name="commit">The <see cref="Commit"/> whose information is to be copied</param>
+        /// <param name="message">Optional override for the message</param>
+        /// <returns>A new <see cref="CommitRewriteInfo"/> object that matches the info for the
+        /// <paramref name="commit"/> with the optional parameters replaced..</returns>
+        public static CommitRewriteInfo From(Commit commit, string message)
+        {
+            return From(commit, null, null, message);
+        }
+
+        /// <summary>
+        /// Build a <see cref="CommitRewriteInfo"/> from the <see cref="Commit"/> passed in,
+        /// optionally overriding some of its properties
+        /// </summary>
+        /// <param name="commit">The <see cref="Commit"/> whose information is to be copied</param>
+        /// <param name="author">Optional override for the author</param>
+        /// <param name="committer">Optional override for the committer</param>
+        /// <returns>A new <see cref="CommitRewriteInfo"/> object that matches the info for the
+        /// <paramref name="commit"/> with the optional parameters replaced..</returns>
+        public static CommitRewriteInfo From(Commit commit, Signature author, Signature committer)
+        {
+            return From(commit, author, committer, null);
+        }
+
         /// <summary>
         /// Build a <see cref="CommitRewriteInfo"/> from the <see cref="Commit"/> passed in,
         /// optionally overriding some of its properties
@@ -46,9 +86,9 @@ public static CommitRewriteInfo From(Commit commit)
         /// <returns>A new <see cref="CommitRewriteInfo"/> object that matches the info for the
         /// <paramref name="commit"/> with the optional parameters replaced..</returns>
         public static CommitRewriteInfo From(Commit commit,
-                                             Signature author = null,
-                                             Signature committer = null,
-                                             string message = null)
+                                             Signature author,
+                                             Signature committer,
+                                             string message)
         {
             var cri = From(commit);
             cri.Author = author ?? cri.Author;
