Update PATH envrionment variable for package manager executable on Windows #25847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Implementation for PowerShell/PowerShell-RFC#391. For the PS team members, here is the internal PR for the equivalent change in CMD: https://microsoft.visualstudio.com/OS/_git/os.2020/pullrequest/10131240
A few implementation decisions:
Check the package manager list only once per process (same as CMD). So, changing the package manager list in registry doesn't affect a PowerShell session that is already running.
When detecting user/system PATH value changes, only check new items PREPENDED or APPENDED to the original string (same as CMD). The detection is made simple, which is not intended to detect complex changes to the user/system PATH.
The PATH update feature is disabled when the
Environment
provider is not available. TheEnvironment
provider is checked only once per PowerShell session (s_environmentProviderEnabled
is thread static).TODO
No test is added yet. Need help to brainstorm the best way to add test automation.
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright header