fix: improve create workspace page for dynamic parameters (coder#18139)

jaaydenh · web-flow · commit 854ef5b07cb1 · 2025-05-30T17:13:16.000-04:00
- Avoid scrolling on workspace creation
- hide auth required badge when authenticated
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
@@ -179,7 +179,7 @@ export const CreateWorkspacePageViewExperimental: FC<
 	}, [error]);
 
 	useEffect(() => {
-		if (form.submitCount > 0 && form.errors) {
+		if (form.submitCount > 0 && Object.keys(form.errors).length > 0) {
 			workspaceNameInputRef.current?.scrollIntoView({
 				behavior: "smooth",
 				block: "center",
diff --git a/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx b/site/src/pages/CreateWorkspacePage/ExternalAuthButton.tsx
@@ -38,8 +38,12 @@ export const ExternalAuthButton: FC<ExternalAuthButtonProps> = ({
 					/>
 				)}
 				<p className="font-semibold text-sm m-0">{auth.display_name}</p>
-				{!auth.optional && (
-					<Badge size="sm" variant={error ? "destructive" : "warning"}>
+				{!auth.authenticated && !auth.optional && (
+					<Badge
+						size="sm"
+						border="none"
+						variant={error ? "destructive" : "warning"}
+					>
 						Required
 					</Badge>
 				)}
