diff --git a/agent/agentssh/agentssh_test.go b/agent/agentssh/agentssh_test.go index ae1aaa92f2ffd..23d9dcc7da3b7 100644 --- a/agent/agentssh/agentssh_test.go +++ b/agent/agentssh/agentssh_test.go @@ -214,7 +214,11 @@ func TestNewServer_CloseActiveConnections(t *testing.T) { } for _, ch := range waitConns { - <-ch + select { + case <-ctx.Done(): + t.Fatal("timeout") + case <-ch: + } } return s, wg.Wait diff --git a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx index d023bbcf4446b..9ec69158c4e84 100644 --- a/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx +++ b/site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx @@ -32,7 +32,7 @@ import { TooltipTrigger, } from "components/Tooltip/Tooltip"; import { Info, Settings, TriangleAlert } from "lucide-react"; -import { type FC, useId } from "react"; +import { type FC, useEffect, useId, useState } from "react"; import type { AutofillBuildParameter } from "utils/richParameters"; import * as Yup from "yup"; @@ -164,14 +164,18 @@ const ParameterField: FC = ({ id, }) => { const value = validValue(parameter.value); - const defaultValue = validValue(parameter.default_value); + const [localValue, setLocalValue] = useState(value); + + useEffect(() => { + setLocalValue(value); + }, [value]); switch (parameter.form_type) { case "dropdown": return (