Unix socket connections are not tested #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Nothing4You opened this issue Jan 28, 2022 · 0 comments · Fixed by #1061

Contributor

Nothing4You commented Jan 28, 2022

As far as I can tell from reading the test code and https://coveralls.io/builds/43227636/source?filename=pymysql%2Fconnections.py#L599 there are no tests for unix socket connections at this time.

It's not that simple to just include them with the current test suite though, as you can't just access the socket inside the service container.

SergeantMenacingGarlic mentioned this issue

Add unix socket connection test #1061

Merged

methane closed this as completed in #1061

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.