[Bug] Fixed fatal error on PHP5.3 using timer

cboden · cboden · commit e13252e34251 · 2013-01-04T19:19:17.000-05:00
PHP5.3 does not support calling $this within a closure
diff --git a/src/React/EventLoop/LibEventLoop.php b/src/React/EventLoop/LibEventLoop.php
@@ -172,7 +172,9 @@ protected function addTimerInternal($interval, $callback, $periodic = false)
 
         $timer->signature = spl_object_hash($timer);
         $timersGc = $this->timersGc;
-        $callback = function () use ($timer, $timersGc) {
+
+        $self = $this;
+        $callback = function () use ($timer, $timersGc, $self) {
             foreach ($timersGc as $resource) {
                 event_free($resource);
             }
@@ -183,7 +185,7 @@ protected function addTimerInternal($interval, $callback, $periodic = false)
                 if ($timer->periodic === true) {
                     event_add($timer->resource, $timer->interval);
                 } else {
-                    $this->cancelTimer($timer->signature);
+                    $self->cancelTimer($timer->signature);
                 }
             }
         };

Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,9 @@ protected function addTimerInternal($interval, $callback, $periodic = false)`
`172`	`172`
`173`	`173`	`$timer->signature = spl_object_hash($timer);`
`174`	`174`	`$timersGc = $this->timersGc;`
`175`		`- $callback = function () use ($timer, $timersGc) {`
	`175`	`+`
	`176`	`+ $self = $this;`
	`177`	`+ $callback = function () use ($timer, $timersGc, $self) {`
`176`	`178`	`foreach ($timersGc as $resource) {`
`177`	`179`	`event_free($resource);`
`178`	`180`	`}`
`@@ -183,7 +185,7 @@ protected function addTimerInternal($interval, $callback, $periodic = false)`
`183`	`185`	`if ($timer->periodic === true) {`
`184`	`186`	`event_add($timer->resource, $timer->interval);`
`185`	`187`	`} else {`
`186`		`- $this->cancelTimer($timer->signature);`
	`188`	`+ $self->cancelTimer($timer->signature);`
`187`	`189`	`}`
`188`	`190`	`}`
`189`	`191`	`};`