re-order parameters

Emyrk · Emyrk · commit ae9dba21d21b · 2022-04-07T10:28:37.000-05:00
diff --git a/coderd/authz/authz.go b/coderd/authz/authz.go
@@ -10,15 +10,15 @@ import (
 
 var ErrUnauthorized = errors.New("unauthorized")
 
-func Authorize(ctx context.Context, subj Subject, res Object, action rbac.Operation) error {
+func Authorize(ctx context.Context, subj Subject, action rbac.Operation, res Object) error {
 	if res.ObjectType == "" {
 		return ErrUnauthorized
 	}
 
 	// Own actions only succeed if the subject owns the resource.
 	if !isAll(action) {
 		// Before we reject this, the user could be an admin with "-all" perms.
-		err := Authorize(ctx, subj, res, rbac.Operation(strings.ReplaceAll(string(action), "-own", "-all")))
+		err := Authorize(ctx, subj, rbac.Operation(strings.ReplaceAll(string(action), "-own", "-all")), res)
 		if err == nil {
 			return nil
 		}
diff --git a/coderd/authz/authz_test.go b/coderd/authz/authz_test.go
@@ -102,7 +102,7 @@ func TestAuthorize(t *testing.T) {
 
 	for _, c := range testCases {
 		t.Run(c.Name, func(t *testing.T) {
-			err := authz.Authorize(context.Background(), c.Subject, c.Resource, c.Action)
+			err := authz.Authorize(context.Background(), c.Subject, c.Action, c.Resource)
 			if c.ExpectedError {
 				require.EqualError(t, err, authz.ErrUnauthorized.Error(), "unauth")
 			} else {
