Allow greater tolerance in RationalTest (exercism#2898)

veloukonst · web-flow · commit 919b7f7b2425 · 2025-01-04T06:56:04.000+08:00
It has been reported that original tolerance was perhaps too strict, possibly preventing valid solutions from passing the test. Adjusting the tolerance to allow other valid solutions. The new tolerance value was copied from the Python implementation. Fixes exercism#2823. [no important files changed]
diff --git a/exercises/practice/rational-numbers/src/test/java/RationalTest.java b/exercises/practice/rational-numbers/src/test/java/RationalTest.java
@@ -8,10 +8,10 @@ public class RationalTest {
 
     // Helper methods
 
-    private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-15;
+    private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-8;
 
     private void assertDoublesEqual(double x, double y) {
-        assertThat(x).isEqualTo(y, within(DOUBLE_EQUALITY_TOLERANCE));
+        assertThat(x).isCloseTo(y, within(DOUBLE_EQUALITY_TOLERANCE));
     }
 
     // Tests

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,10 @@ public class RationalTest {`
`8`	`8`
`9`	`9`	`// Helper methods`
`10`	`10`
`11`		`- private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-15;`
	`11`	`+ private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-8;`
`12`	`12`
`13`	`13`	`private void assertDoublesEqual(double x, double y) {`
`14`		`- assertThat(x).isEqualTo(y, within(DOUBLE_EQUALITY_TOLERANCE));`
	`14`	`+ assertThat(x).isCloseTo(y, within(DOUBLE_EQUALITY_TOLERANCE));`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`// Tests`