build(docs_app): upgrade to latest SW and other fixes #4201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially includes the (relevant) commits from angular/angular#25997 (plus a couple more).
Generated by 🚫 dangerJS |
|
Thanks, @gkalpak! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Includes the following changes to the docs app:
Remove unused files/scripts (that were unnecessarily copied over from angular.io).
Upgrade
@angular/service-workerto 6.1.9.This essentially includes the (relevant) commits from [6.1.x] update angular.io to the new ServiceWorker angular/angular#25997 (plus a couple minor ones).
The current
ngsw-config.jsonseems reasonable, but you might want to tweak it.Remove unused images (mainly to avoid fetching them from the SW and unnecessarily consuming bandwidth).
Replace Angular images and headline with RxJS ones:
a. In the 404 page:
Before:
After:
NOTE:
I hacked together an RxJS sad logo (similar to the Angular one), but you probably want to provide your own.
(Still, it is better than showing the Angular logo 😁)
b. In the "no JavaScript" page (shown when JavaScript is disabled):
Before:
After:
Related issue (if exists):
Fixes #4178.