Move to RedisString (trail 2) #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshadmi
previously approved these changes
Jul 7, 2021
Comment on lines
+509
to
+514
| arg if arg.eq_ignore_ascii_case("NX") && set_option == SetOptions::None => { | ||
| set_option = SetOptions::NotExists | ||
| } | ||
| arg if arg.eq_ignore_ascii_case("XX") && set_option == SetOptions::None => { | ||
| set_option = SetOptions::AlreadyExists | ||
| } |
There was a problem hiding this comment.
NX and XX can now occur only once, but FORMAT can still occur more times, taking its last value?
(consider adding a None value also for FORMAT enum?)
There was a problem hiding this comment.
@oshadmi I didn't really deal with Format since we don't really support BSON yet, the all FORMAT thing needs a review
Co-authored-by: Omer Shadmi <76992134+oshadmi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #394