[3.9] bpo-40998: Fix a refleak in create_filter() (pythonGH-23365) (pythonGH-23369)

tiran · web-flow · commit 35bf8ea7bef7 · 2020-11-18T09:45:29.000-08:00
(cherry picked from commit d1e38d4)
diff --git a/Python/_warnings.c b/Python/_warnings.c
@@ -69,11 +69,14 @@ create_filter(PyObject *category, _Py_Identifier *id, const char *modname)
         }
     } else {
         modname_obj = Py_None;
+        Py_INCREF(modname_obj);
     }
 
     /* This assumes the line number is zero for now. */
-    return PyTuple_Pack(5, action_str, Py_None,
-                        category, modname_obj, _PyLong_Zero);
+    PyObject *filter = PyTuple_Pack(5, action_str, Py_None,
+                                    category, modname_obj, _PyLong_Zero);
+    Py_DECREF(modname_obj);
+    return filter;
 }
 #endif
 

Original file line number	Diff line number	Diff line change
`@@ -69,11 +69,14 @@ create_filter(PyObject category, _Py_Identifier id, const char *modname)`
`69`	`69`	`}`
`70`	`70`	`} else {`
`71`	`71`	`modname_obj = Py_None;`
	`72`	`+ Py_INCREF(modname_obj);`
`72`	`73`	`}`
`73`	`74`
`74`	`75`	`/* This assumes the line number is zero for now. */`
`75`		`- return PyTuple_Pack(5, action_str, Py_None,`
`76`		`- category, modname_obj, _PyLong_Zero);`
	`76`	`+ PyObject *filter = PyTuple_Pack(5, action_str, Py_None,`
	`77`	`+ category, modname_obj, _PyLong_Zero);`
	`78`	`+ Py_DECREF(modname_obj);`
	`79`	`+ return filter;`
`77`	`80`	`}`
`78`	`81`	`#endif`
`79`	`82`