bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile for the (python#17774)

orsenthil · web-flow · commit 5bba60290b4a · 2020-01-03T18:14:18.000-08:00
desired behavior under windows platform.

Suggestion by David Bolen
diff --git a/Lib/test/test_urllibnet.py b/Lib/test/test_urllibnet.py
@@ -1,4 +1,3 @@
-import tempfile
 import unittest
 from test import test_support
 from test.test_urllib2net import skip_ftp_test_on_travis
@@ -224,9 +223,10 @@ def test_multiple_ftp_retrieves(self):
 
         with test_support.transient_internet(self.FTP_TEST_FILE):
             try:
-                for _ in range(self.NUM_FTP_RETRIEVES):
-                    with tempfile.NamedTemporaryFile() as fp:
-                        urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE, fp.name)
+                for file_num in range(self.NUM_FTP_RETRIEVES):
+                    with test_support.temp_dir() as td:
+                        urllib.FancyURLopener().retrieve(self.FTP_TEST_FILE,
+                                                         os.path.join(td, str(file_num)))
             except IOError as e:
                 self.fail("Failed FTP retrieve while accessing ftp url "
                           "multiple times.\n Error message was : %s" % e)
