test(starlette): Remove invalid failed_request_status_code tests (getsentry#3560)

szokeasaurusrex · szokeasaurusrex · commit ccdbffb4909d · 2024-09-24T13:29:51.000+02:00
The Starlette integration tests (as well as the FastAPI integration tests, which hit the same code path as the Starlette integration) include a test where the integrations' `failed_request_status_codes` parameter is set to `[None]`. However, since the parameter is typed as `Optional[list[HttpStatusCodeRange]]`, where `HttpStatusCodeRange = Union[int, Container[int]]`, passing `[None]` for this parameter should not be allowed, per the type hint. Thus, we should not test this input, since the behavior of passing `[None]` is not, and should not be, defined by the API.
diff --git a/tests/integrations/starlette/test_starlette.py b/tests/integrations/starlette/test_starlette.py
@@ -1149,7 +1149,6 @@ def test_span_origin(sentry_init, capture_events):
         ([range(400, 403), 500, 501], 405, False),
         ([range(400, 403), 500, 501], 501, True),
         ([range(400, 403), 500, 501], 503, False),
-        ([None], 500, False),
     ],
 )
 """Test cases for configurable status codes.

Original file line number	Diff line number	Diff line change
`@@ -1149,7 +1149,6 @@ def test_span_origin(sentry_init, capture_events):`
`1149`	`1149`	`([range(400, 403), 500, 501], 405, False),`
`1150`	`1150`	`([range(400, 403), 500, 501], 501, True),`
`1151`	`1151`	`([range(400, 403), 500, 501], 503, False),`
`1152`		`- ([None], 500, False),`
`1153`	`1152`	`],`
`1154`	`1153`	`)`
`1155`	`1154`	`"""Test cases for configurable status codes.`