test(aiohttp): Delete test which depends on AIOHTTP behavior (getsentry#3568)

szokeasaurusrex · web-flow · commit dce589ca49a8 · 2024-09-25T12:48:45.000+02:00
This test was added in getsentry#3554 to ensure that we don't break people's AIOHTTP apps when a request handler returns an invalid response. However, the test broke with a recent AIOHTTP release. After investigating, I believe the test broke because it depends on internal AIOHTTP implementation details which changed in the recent AIOHTTP release. This test likely does not add too much value anyways, since the change in getsentry#3554 includes a comment, which explains why handling the AttributeError is important, so I think we can safely remove it. Fixes getsentry#3567
diff --git a/tests/integrations/aiohttp/test_aiohttp.py b/tests/integrations/aiohttp/test_aiohttp.py
@@ -605,27 +605,6 @@ async def hello(request):
     assert event["spans"][0]["origin"] == "auto.http.aiohttp"
 
 
-@pytest.mark.asyncio
-@pytest.mark.parametrize("invalid_response", (None, "invalid"))
-async def test_invalid_response(
-    sentry_init, aiohttp_client, capture_events, invalid_response
-):
-    sentry_init(integrations=[AioHttpIntegration()])
-
-    async def handler(_):
-        return invalid_response
-
-    app = web.Application()
-    app.router.add_get("/", handler)
-
-    client = await aiohttp_client(app)
-
-    # Invalid response should result on a ServerDisconnectedError in the client side, not an internal server error.
-    # Important to note that the ServerDisconnectedError indicates we have no error server-side.
-    with pytest.raises(ServerDisconnectedError):
-        await client.get("/")
-
-
 @pytest.mark.parametrize(
     ("integration_kwargs", "exception_to_raise", "should_capture"),
     (
