fix: Ignore hidden folders when archiving (coder#4370)

kylecarbs · web-flow · commit 06d7e368abc1 · 2022-10-04T22:27:14.000Z
Fixes coder#4369.
diff --git a/provisionersdk/archive.go b/provisionersdk/archive.go
@@ -75,7 +75,11 @@ func Tar(directory string, limit int64) ([]byte, error) {
 		if err != nil {
 			return err
 		}
-		if strings.HasPrefix(filepath.Base(rel), ".") {
+		if strings.HasPrefix(rel, ".") {
+			if fileInfo.IsDir() && rel != "." {
+				// Don't archive hidden files!
+				return filepath.SkipDir
+			}
 			// Don't archive hidden files!
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,11 @@ func Tar(directory string, limit int64) ([]byte, error) {`
`75`	`75`	`if err != nil {`
`76`	`76`	`return err`
`77`	`77`	`}`
`78`		`- if strings.HasPrefix(filepath.Base(rel), ".") {`
	`78`	`+ if strings.HasPrefix(rel, ".") {`
	`79`	`+ if fileInfo.IsDir() && rel != "." {`
	`80`	`+ // Don't archive hidden files!`
	`81`	`+ return filepath.SkipDir`
	`82`	`+ }`
`79`	`83`	`// Don't archive hidden files!`
`80`	`84`	`return err`
`81`	`85`	`}`