Skip to content

Commit 102b91a

Browse files
authored
Merge pull request #1653 from youknowone/fix-modpow
bump up num-bigint to 0.2.4 to fix modpow
2 parents 31d3fc6 + e84ecaf commit 102b91a

File tree

3 files changed

+7
-23
lines changed

3 files changed

+7
-23
lines changed

Cargo.lock

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/snippets/builtin_pow.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,6 @@ def powtest(type):
5656
for i in range(il, ih + 1):
5757
for j in range(jl, jh + 1):
5858
for k in range(kl, kh + 1):
59-
if j == 1 and k % 2 == 0:
60-
# FIXME: num-bigint bug for this case
61-
# https://github.com/rust-num/num-bigint/pull/113
62-
continue
63-
if i < 0 or k < 0:
64-
# FIXME: num-bigint bug for negative base or mod
65-
# https://github.com/rust-num/num-bigint/pull/114
66-
continue
6759
if k != 0:
6860
if type == float or j < 0:
6961
assert_raises(TypeError, pow, type(i), j, k)
@@ -100,14 +92,6 @@ def test_other():
10092

10193
for i in range(-10, 11):
10294
for j in range(0, 6):
103-
if j == 1:
104-
# FIXME: num-bigint bug for this case
105-
# https://github.com/rust-num/num-bigint/pull/113
106-
continue
107-
if i < 0:
108-
# FIXME: num-bigint bug for negative base
109-
# https://github.com/rust-num/num-bigint/pull/114
110-
continue
11195
for k in range(-7, 11):
11296
if j >= 0 and k != 0:
11397
assert_equal(

vm/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ sha3 = "0.8"
2525
blake2 = "0.8"
2626

2727
num-complex = { version = "0.2.2", features = ["serde"] }
28-
num-bigint = { version = "0.2.3", features = ["serde"] }
28+
num-bigint = { version = "0.2.4", features = ["serde"] }
2929
num-traits = "0.2.8"
3030
num-integer = "0.1.41"
3131
num-rational = "0.2.2"

0 commit comments

Comments
 (0)