Merge pull request #2315 from hyperbora/fix-math-acosh

coolreader18 · web-flow · commit 249f12189654 · 2020-10-30T12:03:59.000-05:00
fix math.acosh
diff --git a/Lib/test/test_math.py b/Lib/test/test_math.py
@@ -260,8 +260,6 @@ def testAcos(self):
         self.assertRaises(ValueError, math.acos, -1 - eps)
         self.assertTrue(math.isnan(math.acos(NAN)))
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def testAcosh(self):
         self.assertRaises(TypeError, math.acosh)
         self.ftest('acosh(1)', math.acosh(1), 0)
diff --git a/vm/src/stdlib/math.rs b/vm/src/stdlib/math.rs
@@ -225,7 +225,15 @@ fn math_radians(x: IntoPyFloat) -> f64 {
 }
 
 // Hyperbolic functions:
-make_math_func!(math_acosh, acosh);
+fn math_acosh(x: IntoPyFloat, vm: &VirtualMachine) -> PyResult<f64> {
+    let x = x.to_f64();
+    if x.is_sign_negative() || x.is_zero() {
+        Err(vm.new_value_error("math domain error".to_owned()))
+    } else {
+        Ok(x.acosh())
+    }
+}
+
 make_math_func!(math_asinh, asinh);
 make_math_func!(math_atanh, atanh);
 make_math_func!(math_cosh, cosh);
