fix maketrans (#5824)

youknowone · web-flow · commit 33af632914cd · 2025-06-23T11:43:18.000+09:00
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
@@ -378,8 +378,6 @@ def test_rindex(self):
         self.assertRaises(ValueError, ('a' * 100).rindex, '\U00100304a')
         self.assertRaises(ValueError, ('\u0102' * 100).rindex, '\U00100304\u0102')
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_maketrans_translate(self):
         # these work with plain translate()
         self.checkequalnofix('bbbc', 'abababc', 'translate',
diff --git a/vm/src/builtins/str.rs b/vm/src/builtins/str.rs
@@ -1416,6 +1416,10 @@ impl PyStr {
                                     "string keys in translate table must be of length 1".to_owned(),
                                 ));
                             }
+                        } else {
+                            return Err(vm.new_type_error(
+                                "keys in translate table must be strings or integers".to_owned(),
+                            ));
                         }
                     }
                     Ok(new_dict.to_pyobject(vm))

Original file line number	Diff line number	Diff line change
`@@ -1416,6 +1416,10 @@ impl PyStr {`
`1416`	`1416`	`"string keys in translate table must be of length 1".to_owned(),`
`1417`	`1417`	`));`
`1418`	`1418`	`}`
	`1419`	`+ } else {`
	`1420`	`+ return Err(vm.new_type_error(`
	`1421`	`+ "keys in translate table must be strings or integers".to_owned(),`
	`1422`	`+ ));`
`1419`	`1423`	`}`
`1420`	`1424`	`}`
`1421`	`1425`	`Ok(new_dict.to_pyobject(vm))`