Fix weakref richcompare (#3913)

Karatuss · yonmilk · web-flow · commit 36649866294d · 2022-07-18T20:59:46.000+09:00
Co-Authored-By: Kim, Yeonwoo &lt;oow214@gmail.com&gt;
diff --git a/Lib/test/test_weakref.py b/Lib/test/test_weakref.py
@@ -228,8 +228,6 @@ def test_proxy_reuse(self):
         self.assertIs(proxy1, proxy2,
                      "proxy object w/out callback should have been re-used")
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_basic_proxy(self):
         o = C()
         self.check_proxy(o, weakref.proxy(o))
diff --git a/vm/src/builtins/weakproxy.rs b/vm/src/builtins/weakproxy.rs
@@ -58,7 +58,7 @@ crate::common::static_cell! {
     static WEAK_SUBCLASS: PyTypeRef;
 }
 
-#[pyimpl(with(GetAttr, SetAttr, Constructor, AsSequence, AsMapping))]
+#[pyimpl(with(GetAttr, SetAttr, Constructor, Comparable, AsSequence, AsMapping))]
 impl PyWeakProxy {
     fn try_upgrade(&self, vm: &VirtualMachine) -> PyResult {
         self.weak.upgrade().ok_or_else(|| new_reference_error(vm))
@@ -88,6 +88,7 @@ impl PyWeakProxy {
         self.try_upgrade(vm)?.repr(vm)
     }
 
+    #[pymethod(magic)]
     fn contains(&self, needle: PyObjectRef, vm: &VirtualMachine) -> PyResult<bool> {
         let obj = self.try_upgrade(vm)?;
         PySequence::contains(&obj, &needle, vm)

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ crate::common::static_cell! {`
`58`	`58`	`static WEAK_SUBCLASS: PyTypeRef;`
`59`	`59`	`}`
`60`	`60`
`61`		`-#[pyimpl(with(GetAttr, SetAttr, Constructor, AsSequence, AsMapping))]`
	`61`	`+#[pyimpl(with(GetAttr, SetAttr, Constructor, Comparable, AsSequence, AsMapping))]`
`62`	`62`	`impl PyWeakProxy {`
`63`	`63`	`fn try_upgrade(&self, vm: &VirtualMachine) -> PyResult {`
`64`	`64`	`self.weak.upgrade().ok_or_else(\|\| new_reference_error(vm))`
`@@ -88,6 +88,7 @@ impl PyWeakProxy {`
`88`	`88`	`self.try_upgrade(vm)?.repr(vm)`
`89`	`89`	`}`
`90`	`90`
	`91`	`+ #[pymethod(magic)]`
`91`	`92`	`fn contains(&self, needle: PyObjectRef, vm: &VirtualMachine) -> PyResult<bool> {`
`92`	`93`	`let obj = self.try_upgrade(vm)?;`
`93`	`94`	`PySequence::contains(&obj, &needle, vm)`