replace only bufferinternal for release

youknowone · youknowone · commit 550b4e042fa8 · 2021-09-13T00:24:38.000+09:00
diff --git a/vm/src/builtins/memory.rs b/vm/src/builtins/memory.rs
@@ -139,7 +139,8 @@ impl PyMemoryView {
             unsafe {
                 // SAFETY: this branch is only once accessible form _release and guarded by AtomicCell released
                 let buffer: &std::cell::UnsafeCell<PyBuffer> = std::mem::transmute(&self.buffer);
-                *buffer.get() = PyBuffer::new(Released, self.buffer.options.clone());
+                let buffer = &mut *buffer.get();
+                let _ = std::mem::replace(&mut buffer.internal, PyRc::new(Released));
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,8 @@ impl PyMemoryView {`
`139`	`139`	`unsafe {`
`140`	`140`	`// SAFETY: this branch is only once accessible form _release and guarded by AtomicCell released`
`141`	`141`	`let buffer: &std::cell::UnsafeCell<PyBuffer> = std::mem::transmute(&self.buffer);`
`142`		`- *buffer.get() = PyBuffer::new(Released, self.buffer.options.clone());`
	`142`	`+ let buffer = &mut *buffer.get();`
	`143`	`+ let _ = std::mem::replace(&mut buffer.internal, PyRc::new(Released));`
`143`	`144`	`}`
`144`	`145`	`}`
`145`	`146`	`}`