Raise TypeError if BaseException receives Keyword arguments

crazymerlyn · youknowone · commit 76236682564d · 2024-09-24T11:57:37.000+09:00
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
@@ -668,8 +668,6 @@ def testChainingDescriptors(self):
         e.__suppress_context__ = False
         self.assertFalse(e.__suppress_context__)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def testKeywordArgs(self):
         # test that builtin exception don't take keyword args,
         # but user-defined subclasses can if they want
diff --git a/vm/src/exceptions.rs b/vm/src/exceptions.rs
@@ -649,6 +649,9 @@ impl Constructor for PyBaseException {
     type Args = FuncArgs;
 
     fn py_new(cls: PyTypeRef, args: FuncArgs, vm: &VirtualMachine) -> PyResult {
+        if cls.is(PyBaseException::class(&vm.ctx)) && !args.kwargs.is_empty() {
+            return Err(vm.new_type_error("BaseException() takes no keyword arguments".to_owned()));
+        }
         PyBaseException::new(args.args, vm)
             .into_ref_with_type(vm, cls)
             .map(Into::into)
