pystr.rs isdecimal() checks not only ASCII but also Unicode decimals

Jungwon-Lee · web-flow · commit 7b79c09c3c74 · 2021-11-20T16:08:27.000+09:00
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
@@ -661,8 +661,6 @@ def test_isascii(self):
         self.assertFalse("\u20ac".isascii())
         self.assertFalse("\U0010ffff".isascii())
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_isdecimal(self):
         self.checkequalnofix(False, '', 'isdecimal')
         self.checkequalnofix(False, 'a', 'isdecimal')
diff --git a/vm/src/builtins/pystr.rs b/vm/src/builtins/pystr.rs
@@ -709,7 +709,8 @@ impl PyStr {
 
     #[pymethod]
     fn isdecimal(&self) -> bool {
-        !self.bytes.is_empty() && self.char_all(|c| c.is_ascii_digit())
+        !self.bytes.is_empty()
+            && self.char_all(|c| GeneralCategory::of(c) == GeneralCategory::DecimalNumber)
     }
 
     #[pymethod(name = "__mod__")]

Original file line number	Diff line number	Diff line change
`@@ -709,7 +709,8 @@ impl PyStr {`
`709`	`709`
`710`	`710`	`#[pymethod]`
`711`	`711`	`fn isdecimal(&self) -> bool {`
`712`		`- !self.bytes.is_empty() && self.char_all(\|c\| c.is_ascii_digit())`
	`712`	`+ !self.bytes.is_empty()`
	`713`	`+ && self.char_all(\|c\| GeneralCategory::of(c) == GeneralCategory::DecimalNumber)`
`713`	`714`	`}`
`714`	`715`
`715`	`716`	`#[pymethod(name = "__mod__")]`