Merge pull request #2992 from moreal/bugfix/correct-object-repr

youknowone · web-flow · commit 818688daab08 · 2021-09-02T22:20:42.000+09:00
Correct `object.__repr__` format
diff --git a/Lib/test/test_reprlib.py b/Lib/test/test_reprlib.py
@@ -318,8 +318,6 @@ class bar:
         # Module name may be prefixed with "test.", depending on how run.
         self.assertEqual(repr(bar.bar), "<class '%s.bar'>" % bar.__name__)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_instance(self):
         self._check_path_limitations('baz')
         write_file(os.path.join(self.subpkgname, 'baz.py'), '''\
@@ -332,8 +330,6 @@ class baz:
         self.assertTrue(repr(ibaz).startswith(
             "<%s.baz object at 0x" % baz.__name__))
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_method(self):
         self._check_path_limitations('qux')
         eq = self.assertEqual
diff --git a/vm/src/builtins/object.rs b/vm/src/builtins/object.rs
@@ -185,7 +185,11 @@ impl PyBaseObject {
     /// Return repr(self).
     #[pymethod(magic)]
     fn repr(zelf: PyObjectRef) -> String {
-        format!("<{} object at {:#x}>", zelf.class().name, zelf.get_id())
+        format!(
+            "<{} object at {:#x}>",
+            zelf.class().tp_name(),
+            zelf.get_id()
+        )
     }
 
     #[pyclassmethod(magic)]
