Directly return Ok / Err

philippeitis · web-flow · commit be2a41b2340e · 2020-02-27T13:41:44.000-08:00
diff --git a/vm/src/obj/objlist.rs b/vm/src/obj/objlist.rs
@@ -475,9 +475,9 @@ impl PyList {
             let new_elements = sequence::seq_mul(&self.borrow_sequence(), counter)
                 .cloned()
                 .collect();
-            Ok(vm.ctx.new_list(new_elements))
+            return Ok(vm.ctx.new_list(new_elements));
         }
-        Err(vm.new_memory_error("".to_owned()))
+        return Err(vm.new_memory_error("".to_owned()));
     }
 
     #[pymethod(name = "__rmul__")]
@@ -492,9 +492,9 @@ impl PyList {
                 .cloned()
                 .collect();
             zelf.elements.replace(new_elements);
-            Ok(zelf)
+            return Ok(*zelf);
         }
-        Err(vm.new_memory_error("".to_owned()))
+        return Err(vm.new_memory_error("".to_owned()));
     }
 
     #[pymethod]

Original file line number	Diff line number	Diff line change
`@@ -475,9 +475,9 @@ impl PyList {`
`475`	`475`	`let new_elements = sequence::seq_mul(&self.borrow_sequence(), counter)`
`476`	`476`	`.cloned()`
`477`	`477`	`.collect();`
`478`		`- Ok(vm.ctx.new_list(new_elements))`
	`478`	`+ return Ok(vm.ctx.new_list(new_elements));`
`479`	`479`	`}`
`480`		`- Err(vm.new_memory_error("".to_owned()))`
	`480`	`+ return Err(vm.new_memory_error("".to_owned()));`
`481`	`481`	`}`
`482`	`482`
`483`	`483`	`#[pymethod(name = "__rmul__")]`
`@@ -492,9 +492,9 @@ impl PyList {`
`492`	`492`	`.cloned()`
`493`	`493`	`.collect();`
`494`	`494`	`zelf.elements.replace(new_elements);`
`495`		`- Ok(zelf)`
	`495`	`+ return Ok(*zelf);`
`496`	`496`	`}`
`497`		`- Err(vm.new_memory_error("".to_owned()))`
	`497`	`+ return Err(vm.new_memory_error("".to_owned()));`
`498`	`498`	`}`
`499`	`499`
`500`	`500`	`#[pymethod]`