Merge pull request #4756 from JaeyoungAhn/modify_comparison

youknowone · web-flow · commit d5975a402338 · 2023-03-25T19:46:12.000+09:00
resolve unittest error in test_sort.py
diff --git a/Lib/test/test_sort.py b/Lib/test/test_sort.py
@@ -383,8 +383,6 @@ def test_not_all_tuples(self):
         self.assertRaises(TypeError, [('a', 1), (1, 'a')].sort)
         self.assertRaises(TypeError, [(1, 'a'), ('a', 1)].sort)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_none_in_tuples(self):
         expected = [(None, 1), (None, 2)]
         actual = sorted([(None, 2), (None, 1)])
diff --git a/vm/src/iter.rs b/vm/src/iter.rs
@@ -34,6 +34,9 @@ pub trait PyExactSizeIterator<'a>: ExactSizeIterator<Item = &'a PyObjectRef> + S
         let lhs_len = lhs.len();
         let rhs_len = rhs.len();
         for (a, b) in lhs.zip(rhs) {
+            if vm.bool_eq(a, b)? {
+                continue;
+            }
             let ret = if less {
                 vm.bool_seq_lt(a, b)?
             } else {
