Fix __hash__ not to perforn unnecessary downcast

youknowone · youknowone · commit e4adaf2a6727 · 2021-10-15T05:03:48.000+09:00
diff --git a/vm/src/types/slot.rs b/vm/src/types/slot.rs
@@ -486,8 +486,8 @@ pub trait Hashable: PyValue {
 
     #[inline]
     #[pymethod]
-    fn __hash__(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyResult<PyHash> {
-        Self::hash(&zelf, vm)
+    fn __hash__(zelf: PyObjectRef, vm: &VirtualMachine) -> PyResult<PyHash> {
+        Self::slot_hash(&zelf, vm)
     }
 
     fn hash(zelf: &PyRef<Self>, vm: &VirtualMachine) -> PyResult<PyHash>;

Original file line number	Diff line number	Diff line change
`@@ -486,8 +486,8 @@ pub trait Hashable: PyValue {`
`486`	`486`
`487`	`487`	`#[inline]`
`488`	`488`	`#[pymethod]`
`489`		`- fn __hash__(zelf: PyRef<Self>, vm: &VirtualMachine) -> PyResult<PyHash> {`
`490`		`- Self::hash(&zelf, vm)`
	`489`	`+ fn __hash__(zelf: PyObjectRef, vm: &VirtualMachine) -> PyResult<PyHash> {`
	`490`	`+ Self::slot_hash(&zelf, vm)`
`491`	`491`	`}`
`492`	`492`
`493`	`493`	`fn hash(zelf: &PyRef<Self>, vm: &VirtualMachine) -> PyResult<PyHash>;`