Skip to content

Removing the old import #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
palaviv opened this issue Jul 3, 2019 · 1 comment
Closed

Removing the old import #1100

palaviv opened this issue Jul 3, 2019 · 1 comment

Comments

@palaviv
Copy link
Contributor

palaviv commented Jul 3, 2019

Now that we can import using importlib I would like to remove the old import (import::import_module). The problem is that some of the modules that use the old import are needed for importlib import to work (_io, _thread). For example in io_open we import io using the old import so we can create an instance of FileIO. We can't use the new import as in that phase it is not initialized yet.
How do you think we should solve this problem? Should we remove all use of import in the modules used by importlib? This will require us to have a struct that implements PyValue for every class.

@palaviv
Copy link
Contributor Author

palaviv commented Jul 3, 2019

I was wrong about this as can be seen in #1102.

@palaviv palaviv closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant