Skip to content

int type casting with negative base value do not raise valueError #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hqsz opened this issue Sep 23, 2019 · 0 comments · Fixed by #1406
Closed

int type casting with negative base value do not raise valueError #1405

hqsz opened this issue Sep 23, 2019 · 0 comments · Fixed by #1406
Labels
C-compat A discrepancy between RustPython and CPython

Comments

@hqsz
Copy link
Contributor

hqsz commented Sep 23, 2019

Feature

print(int('1', base=-1))

if base is negative value, it should be valueError

Actual result

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: Int value cannot fit into Rust u32

Expected result

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: int() base must be >= 2 and <= 36, or 0
@hqsz hqsz added the C-compat A discrepancy between RustPython and CPython label Sep 23, 2019
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 23, 2019
@hqsz
Fix int type casting error with negative base value
c06eaee 
Change base type from u32 to i32

Fixed: RustPython#1405
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 23, 2019
@hqsz
Fix int type casting error with negative base value
008093c 
Change base type from u32 to i32

Fixed: RustPython#1405
@hqsz hqsz mentioned this issue Sep 23, 2019
Merged
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 24, 2019
@hqsz
Fix int type casting error with negative base value
c07aa7e 
Change base type from u32 to i32

Fixed: RustPython#1405
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 24, 2019
@hqsz
Fix int type casting error with negative base value
c9cd242 
Change base type from u32 to PyIntRef

Fixed: RustPython#1405
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 24, 2019
@hqsz
Fix int type casting error with negative base value
dd81aea 
Change base type from u32 to PyIntRef

Fixed: RustPython#1405
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 24, 2019
@hqsz
Fix int type casting error with negative base value
188e485 
Change base type from u32 to PyIntRef

Fixed: RustPython#1405
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 24, 2019
@hqsz
Fix int type casting error with negative base value
545e9d3 
Change base type from u32 to PyIntRef

Fixed: RustPython#1405
@hqsz hqsz mentioned this issue Sep 25, 2019
Closed
hqsz added a commit to hqsz/RustPython that referenced this issue Sep 26, 2019
@hqsz
Fix int type casting error with negative base value
6ee9af0 
Change base type from u32 to PyIntRef

Fixed: RustPython#1405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-compat A discrepancy between RustPython and CPython
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix int type casting error with negative base value hqsz/RustPython
1 participant
@hqsz