Looks like string_expected_methods includes everything that dir('foobar') contains in cpython, and objstr.rs has an implementation of each of those - think this ticket can be closed.

I would disagree.

isdecimal is not implemented
maketrans is also not implemented

My mistake, you're correct - misinterpreted whats_left_to_implement - looks like the following all need doing:

string . __dir__
string . __doc__
string . __format__
string . __ge__
string . __getnewargs__
string . __init_subclass__
string . __iter__
string . __le__
string . __mod__
string . __reduce__
string . __reduce_ex__
string . __rmod__
string . __rmul__
string . __setattr__
string . __sizeof__
string . __subclasshook__
string . encode
string . format_map
string . isdecimal
string . isprintable
string . maketrans
string . translate

Looks like the following (maybe more) have already been implemented:

string . isdecimal
string . __ge__
string . __doc__
string . __format__

implement str.isprintable #1024

@windelbouwman What other work remains waiting for completion and implementation under this question? I am happy to contribute my spare time to this issue.

@longwusha did you run the what is left script to check missing methods on the str type?

@windelbouwman

When I ran the what is left script, I got these missing methods on the str type:

str.__getnewargs__
str.__init_subclass__
str.__iter__
str.__rmod__
str.__sizeof__
str.__subclasshook__
str.format_map

I am not sure are there any other people working on these.

@windelbouwman

As we can see, some one was trying to implement str.iter in #593 . But it seems that he has no interest or time to continue this work, so I want to start to implement other missing methods on the str type based on his work.

It seems that since his last commit (four months ago) the code has undergone a lot of changes, I hope that you can provide some suggestions to help me get started. I will be very grateful for your suggestion.

@longwusha I think string iteration already works, at least I can use x = iter("fu"). You might want to try and import a module you would like to use, and see what problem you hit. That's at least a good way to start working on something.

If you like you can pickup the work from #593, since this work was abandoned. Adding a method to an object is a very good way to get yourself up and running with the codebase. Make sure to create a test snippet in the tests/snippets directory for the function you add. When you have created something, you can create a pull request, then we can review what you did.

Also, str.format_map might be a nice challenge to work on. We already have string formatting functions in cformat.rs and format.rs which you could probably re-use.

Another method which might be a good starter is the int.__rdivmod__ method. Try to create some testcases for this, and then implement the method.

Thank you very much for your good advice, I will try to start with str.format_map.

str class is now practically done. See #1346 for __init_subclass__. __getnewargs__ maybe better to be coverd in pickle issue.