Skip to content

Add call_or_unsupported to remaining operations #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BojanKogoj opened this issue Nov 17, 2018 · 1 comment
Closed

Add call_or_unsupported to remaining operations #198

BojanKogoj opened this issue Nov 17, 2018 · 1 comment
Labels
good first issue Good for newcomers

Comments

@BojanKogoj
Copy link
Contributor

Changes needed in https://github.com/RustPython/RustPython/blob/master/vm/src/vm.rs
Similar to what was done in #197, remaining operations (add, div, pow...) need to call call_or_unsupported.

For example replace

self.call_method(&a, "__truediv__", vec![b])

with

self.call_or_unsupported(a, b, "__truediv__", "__rtruediv__", "/")
@windelbouwman windelbouwman added the good first issue Good for newcomers label Nov 17, 2018
@OddCoincidence OddCoincidence mentioned this issue Feb 17, 2019
Merged
@chylli
Copy link

chylli commented Mar 11, 2019

Seems all work done. I guess this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chylli @BojanKogoj @windelbouwman @OddCoincidence