Skip to content

collections.deque does not have __rmul__ method #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2812
sobolevn opened this issue Aug 10, 2021 · 2 comments · Fixed by #2844
Closed
Tracked by #2812

collections.deque does not have __rmul__ method #2834

sobolevn opened this issue Aug 10, 2021 · 2 comments · Fixed by #2844
Assignees
@sobolevn
Labels
good first issue Good for newcomers

Comments

@sobolevn
Copy link
Contributor

Feature

CPython:

>>> from collections import deque
>>> deque((1, 2)).__rmul__(2)
deque([1, 2, 1, 2])

RustPython:

>>>>> from collections import deque
>>>>> deque((1, 2)).__rmul__(2)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'deque' object has no attribute '__rmul__'
@youknowone youknowone added the good first issue Good for newcomers label Aug 10, 2021
@DimitrisJim
Copy link
Member

DimitrisJim commented Aug 10, 2021 •
edited
Loading

huh, I missed this in #2812. I'll update the issue there and close this up to keep them all in one spot. Take a look over at it to see I haven't missed anything else (pretty sure I got the rest of them).

Edit: read up on task lists, separate issues is part of their usage hah

@DimitrisJim DimitrisJim reopened this Aug 10, 2021
@DimitrisJim DimitrisJim mentioned this issue Aug 10, 2021
Closed
6 tasks
@sobolevn
Copy link
Contributor Author

I am working on this issue right now 🙂
I will submit a PR later tomorrow.

sobolevn added a commit to sobolevn/RustPython that referenced this issue Aug 11, 2021
@sobolevn
Adds __rmul__ to collections.deque, refs RustPython#2834
462f4b0
@sobolevn sobolevn mentioned this issue Aug 11, 2021
Merged
sobolevn added a commit to sobolevn/RustPython that referenced this issue Aug 11, 2021
@sobolevn
Adds __rmul__ to collections.deque, refs RustPython#2834
98a075f
DimitrisJim pushed a commit that referenced this issue Aug 11, 2021
@sobolevn
Adds __rmul__ to collections.deque (#2844)
0906728 
* Adds `__rmul__` to `collections.deque`, refs #2834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds __rmul__ to collections.deque sobolevn/RustPython
3 participants
@youknowone @sobolevn @DimitrisJim