-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Relocate object protocol implementation from vm #3324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Should |
Nope, that's probably going to be part of another protocol file containing call related methods. |
So, that function can be called from |
yeah, call it directly via |
Thanks! This is finally done with all of your help! |
Fabulous! I think this issue could be closed. |
this is done! thank you everyone who contributed in this issue! |
For now, Object protocol methods are (mostly) thin wrapper of matching vm functions. Because we don't need to have duplicated functions for same features, they need to be moved from vm to object protocol functions.
vm
path:vm/src/vm.rs
vm/src/protocol/object.rs
The matching vm functions are easy to find because object methods are calling it.
vm.get_attribute
toobj.get_attr
#3331vm.set_attr
toobj.set_attr
#3338vm.del_attr
toobj.del_attr
#3341vm.rich_compare
toobj.rich_compare
#3347vm.to_repr
toobject.repr
#3364vm.to_str
toobj.str
#3349Becasue relocating each function will cause many code editing, every new PR for each function is recommended for easier review.
Reference:
The text was updated successfully, but these errors were encountered: