Skip to content

mmap module for windows #3847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
youknowone opened this issue Jul 8, 2022 · 3 comments
Open

mmap module for windows #3847

youknowone opened this issue Jul 8, 2022 · 3 comments
Assignees

Comments

@youknowone
Copy link
Member

we added linux mmap in #3755

adding initializer and a few tuning will let windows also run the module.

@youknowone youknowone added good first issue Good for newcomers A-stdlib labels Jul 8, 2022
@eaeiv
Copy link

eaeiv commented Jul 11, 2022

I would like to claim this issue. I'm currently reading through the relevant python docs, linked threads, and the src. If anyone has any suggestions at where to direct my attention, it would be greatly appreciated.

@youknowone
Copy link
Member Author

youknowone commented Jul 12, 2022

Hello, I have rough steps but I don't have detailed descriptions.

  1. Try to change memmap2 in stdlib/Cargo.toml to cover windows.
  2. The major difference of windows version is constructor. We can start with constructor and try to solve other stuff later.
  3. Run test_mmap to check how it is going. cargo run Lib/test/test_mmap.py. You don't need to make everything working for single PR.

@killme2008 do you have any advice?

@killme2008
Copy link
Contributor

@youknowone I don't have more advice, it's a good guide to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants