Skip to content

Add co_freevars to code object #4502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DimitrisJim opened this issue Feb 14, 2023 · 0 comments · Fixed by #4509
Closed

Add co_freevars to code object #4502

DimitrisJim opened this issue Feb 14, 2023 · 0 comments · Fixed by #4509
Labels
C-compat A discrepancy between RustPython and CPython good first issue Good for newcomers

Comments

@DimitrisJim
Copy link
Member

Opening this separately from #1838 since it also seems like a good first issue.

Currently, code objects are missing the co_freevars attribute:

def foo(a, b):
    def bar(c, d):
        print(a, b, c, d)

In RustPython:

>>>>> foo.__code__.co_freevars
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'code' object has no attribute 'co_freevars'

While in Python:

>>> foo.__code__.co_freevars
('a', 'b')

looking at the other methods on PyCode should help, the implementation should be similar to others there that return a tuple.
@DimitrisJim DimitrisJim added good first issue Good for newcomers C-compat A discrepancy between RustPython and CPython labels Feb 14, 2023
@minhrongcon2000 minhrongcon2000 mentioned this issue Feb 16, 2023
Merged
@DimitrisJim DimitrisJim mentioned this issue Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-compat A discrepancy between RustPython and CPython good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add co_freevars to code object minhrongcon2000/RustPython
1 participant
@DimitrisJim