Skip to content

Add -X int_max_str_digits and PYTHONINTMAXSTRDIGITS environment variable #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DimitrisJim opened this issue Jun 20, 2023 · 2 comments · Fixed by #5021
Closed

Add -X int_max_str_digits and PYTHONINTMAXSTRDIGITS environment variable #5019

DimitrisJim opened this issue Jun 20, 2023 · 2 comments · Fixed by #5021
Assignees
Labels
C-compat A discrepancy between RustPython and CPython good first issue Good for newcomers

Comments

@DimitrisJim
Copy link
Member

Feature

Follow up to #5010

These just set the value of int_max_str_digits via an implementation specific command line flag (-X) and/or the environment variable. These need to be accepted in settings.rs and stored in the Settings struct. Flag::from_settings should be updated to pass the value along.

test_int_max_str_digits in test_cmd_line.py is a good place to evaluate changes, hopefully (but not necessarily) the test might will succeed after this change. You can run it locally with:

cargo run --release --features ssl,jit -- -m test -u all --slowest --fail-env-changed -v test_cmd_line`

to get some early feedback.

@DimitrisJim DimitrisJim added good first issue Good for newcomers C-compat A discrepancy between RustPython and CPython labels Jun 20, 2023
@mehboobali98
Copy link

Hi, can I work on this? TIA.

@DimitrisJim
Copy link
Member Author

Sure, go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-compat A discrepancy between RustPython and CPython good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants