freeze stdlib in WASM #1180
Merged
freeze stdlib in WASM #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Now we can use stdlib in wasm right? |
windelbouwman
approved these changes
Jul 26, 2019
| @@ -10,6 +10,10 @@ edition = "2018" | |||
| [lib] | |||
| crate-type = ["cdylib", "rlib"] | |||
|
|
|||
| [features] | |||
| default = ["freeze-stdlib"] | |||
| freeze-stdlib = ["rustpython-vm/freeze-stdlib"] | |||
There was a problem hiding this comment.
Nice usage of options! I think the name is good. Another viable name for this option might be include-stdlib to indicate the inclusion of the the standard library for people who are unfamiliar with the concept of freezing. But I think most people will probably know the idea of freeze.
This looks good to me!
coolreader18
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1142. We did not reach a conclusion there if we should make this the default. I can remove the default if we will decide against this.