Implement itertools.tee #1458

j30ng · 2019-10-03T18:44:08Z

Hi, this is my first draft of itertools.tee. I also added some tests for it. Please review, and let me know if there are any bugs to be fixed, or improvements I can make. Thanks.

youknowone · 2019-10-04T01:54:15Z

vm/src/stdlib/itertools.rs

+        };
+
+        let copyable = if objtype::class_has_attr(&iterable.class(), "__copy__") {
+            vm.call_method(&iterable, "__copy__", PyFuncArgs::from(vec![]))?


It seems this line is not tested by the new snippets tests. Adding one will be great

* Test `__copy__` method for `tee` objects works properly. * Cover the case where the iterable argument passed to `itertools.tee()` has `__copy__` method implemented.

j30ng added 2 commits October 4, 2019 02:59

Implement built-in itertools.tee

301e5a9

Add Testcases

048ec3e

j30ng changed the title ~~Itertools tee~~ Implement itertools.tee Oct 3, 2019

Use Rc::clone(&rc) instead of rc.clone()

5351b7d

youknowone reviewed Oct 4, 2019

View reviewed changes

j30ng added 2 commits October 4, 2019 15:44

Add Tests

418de0f

* Test `__copy__` method for `tee` objects works properly. * Cover the case where the iterable argument passed to `itertools.tee()` has `__copy__` method implemented.

Fix Bug in tee.__next__ + Add Test

0b7da12

windelbouwman merged commit faee9e3 into RustPython:master Oct 4, 2019

j30ng deleted the itertools-tee branch October 4, 2019 16:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement itertools.tee #1458

Implement itertools.tee #1458

j30ng commented Oct 3, 2019

youknowone Oct 4, 2019 •

edited

Loading

Implement itertools.tee #1458

Implement itertools.tee #1458

Conversation

j30ng commented Oct 3, 2019

youknowone Oct 4, 2019 • edited Loading

Choose a reason for hiding this comment

youknowone Oct 4, 2019 •

edited

Loading