Skip to content

CI build and deploy demo page on master branch #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

shinglyu
Copy link
Contributor

@shinglyu shinglyu commented Dec 4, 2018

I don't think Travis got everything it need, let me open a PR to test the build

.travis.yml Outdated
github-token: $WEBSITE_GITHUB_TOKEN # Set in the settings page of your repository, as a secure variable
keep-history: true
on:
branch: master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest still to create a seperate branch next to master which we can use to release less frequent to the demo site. Maybe we could introduce a release branch? We could then manually merge the master branch once or twice a month to update the latest release branch status. This way we would save cpu cycles on travis services.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Let me change this. After merge I'll manually push a branch.

@shinglyu
Copy link
Contributor Author

shinglyu commented Dec 6, 2018

I restricted the deployment to only the release branch (to be pushed yet). I also restrict the task for building documentation and WASM modules to only the release branch, so we don't waste time building documentations on PRs to master branch.

@windelbouwman windelbouwman merged commit f8f9fa7 into master Dec 7, 2018
@windelbouwman windelbouwman deleted the travis-demo branch February 15, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants