Skip to content

added __add__ method to collections.deque #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2021
Merged

added __add__ method to collections.deque #2949

merged 1 commit into from
Aug 26, 2021

Conversation

stromberger
Copy link
Contributor

resolve #2835

add deque.__add__ method

@stromberger stromberger mentioned this pull request Aug 23, 2021
Closed
@youknowone
Copy link
Member

@eldpswp99 would you review this PR?

eldpswp99
eldpswp99 suggested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@eldpswp99 eldpswp99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we have extend function of PyDeque, we can use this. This has length check logic, the code can be more clear.

eldpswp99
eldpswp99 suggested changes Aug 24, 2021
View reviewed changes
@DimitrisJim DimitrisJim self-requested a review August 24, 2021 03:44
DimitrisJim
DimitrisJim previously requested changes Aug 24, 2021
View reviewed changes
@DimitrisJim
Copy link
Member

Thanks for updating this, could you resolve the conflicts that have come up?

@DimitrisJim DimitrisJim dismissed their stale review August 25, 2021 12:13

Review addressed.

DimitrisJim
DimitrisJim approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. not sure why the option to run the actions isn't showing for me though.

@fanninpm
Copy link
Contributor

not sure why the option to run the actions isn't showing for me though.

Is it because of the merge commit? Perhaps a rebase is needed.

@DimitrisJim DimitrisJim merged commit 9203cb3 into RustPython:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldpswp99 eldpswp99 eldpswp99 requested changes

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collections.deque doesn't have __add__ method
5 participants
@stromberger @youknowone @DimitrisJim @fanninpm @eldpswp99