Skip to content

Fix outdated test_userlist #3916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix outdated test_userlist #3916

merged 1 commit into from
Jul 18, 2022

Conversation

youknowone
Copy link
Member

requested by @fanninpm

#3910 (comment)

@youknowone youknowone requested a review from fanninpm July 18, 2022 13:18
fanninpm
fanninpm approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be careful with merge conflicts, but otherwise LGTM.

@fanninpm
Copy link
Contributor

That test_views_mapping unexpected success is likely a fluke.

@youknowone
Copy link
Member Author

that was an invisible conflict to #3898

@youknowone youknowone merged commit 9878d72 into RustPython:main Jul 18, 2022
@youknowone youknowone deleted the fix-userlist branch July 18, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanninpm fanninpm fanninpm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @fanninpm