-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update _mut_iter_equal_skeleton
method
#3968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
line 352 is not related to string. try to print its type like |
By watching CI, it is causing dead-lock. it didn't finish during 4 hours. |
Now, two list method |
Nice catch! The changed codes seem totally fine to me. Please check unexpected success in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't leave these things behind in the code. They're not there in CPython.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@qingshi163 could you review this PR? |
As I remember, the guard or borrower is to optimize the compare by check if the class is not the heap type, so we can reuse the compare function in each loop. Also to use rich_compare_bool we cannot reuse the PyTypeRef for the compared object but this will be no more the issue if we can fetch the PyType atomicly in the future. Yes, the correctness is more important than performance, but if you can solve the problem without drawback the performance could be amazing. if not please advise the issue or the failing point of the current implement, so we could see why this is not going to work. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qingshi163 I created an issue to refer this pr #4008
@TwoPair Thank you!
This code is tested based on
list_tests.py::CommonTest::test_remove
,except for lines
352~358
that seem related tostr
test.