@DimitrisJim was wondering if you could help me out. cargo run -- Lib/test/test_binascii.py passes locally, but it seems like some of the binascii tests are failing here. Is there a difference? I'm also unsure why test_ioctl, test_urllib, etc. would be failing if I haven't done any work on them.

Thanks for all your help so far!

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.

Seems like test_urllib has a test that indirectly uses the changes. (test_ioctl seems to just be skipped after glancing through the ci logs so you can ignore that).

As @fanninpm mentioned, you should use -- -m test to run these (running with cargo run -- Lib/test/test_binascii.py might not invoke the test runner in the same way, as far as I can tell).

I'll try and make some time to check through the code to see if I can spot where any issues might be and thanks for working on it!

Looks like test_urllib is failing because we're not checking for Incorrect padding. It's marked as an expected failure in test_binascii.py, so that's what I'm working on now

@DimitrisJim I think (fingers crossed) this is done?